improve Android Network Security config #23429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@gengjiawen @Salakar @hey99xx please review |
react-native-bot
added
Platform: Android
Salakar
approved these changes
Feb 13, 2019
|
@dulmandakh thanks for this, good idea changing this to limit it specifically to API 28; LGTM |
gengjiawen
approved these changes
Feb 13, 2019
cpojer
approved these changes
Feb 13, 2019
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 13, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@dulmandakh merged commit 5747094 into |
grabbou
pushed a commit
that referenced
this pull request
Feb 13, 2019
Summary: This PR is trying to improve Android Network Security configuration introduced in 84572c4. I found that Android merges all manifest files into a single manifest file when building an app, so this PR provides AndroidManifest.xml with network security config in debug folder, that will be used only for debug builds. Also the network security configuration will be applied to only app that target API 28. Moved security config file to xml-v28, so that it'll only visible to API 28 and above. See https://developer.android.com/studio/build/manifest-merge [Android] [Changed] - Android Network Security configuration. Pull Request resolved: #23429 Differential Revision: D14065124 Pulled By: cpojer fbshipit-source-id: 0f5ac5addbe968ed7e5cb57f356e2572de2690a8
hramos
removed
Import Started
grabbou
pushed a commit
that referenced
this pull request
Feb 18, 2019
Summary: This PR is trying to improve Android Network Security configuration introduced in 84572c4. I found that Android merges all manifest files into a single manifest file when building an app, so this PR provides AndroidManifest.xml with network security config in debug folder, that will be used only for debug builds. Also the network security configuration will be applied to only app that target API 28. Moved security config file to xml-v28, so that it'll only visible to API 28 and above. See https://developer.android.com/studio/build/manifest-merge [Android] [Changed] - Android Network Security configuration. Pull Request resolved: #23429 Differential Revision: D14065124 Pulled By: cpojer fbshipit-source-id: 0f5ac5addbe968ed7e5cb57f356e2572de2690a8
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: This PR is trying to improve Android Network Security configuration introduced in facebook@84572c4. I found that Android merges all manifest files into a single manifest file when building an app, so this PR provides AndroidManifest.xml with network security config in debug folder, that will be used only for debug builds. Also the network security configuration will be applied to only app that target API 28. Moved security config file to xml-v28, so that it'll only visible to API 28 and above. See https://developer.android.com/studio/build/manifest-merge [Android] [Changed] - Android Network Security configuration. Pull Request resolved: facebook#23429 Differential Revision: D14065124 Pulled By: cpojer fbshipit-source-id: 0f5ac5addbe968ed7e5cb57f356e2572de2690a8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is trying to improve Android Network Security configuration introduced in 84572c4. I found that Android merges all manifest files into a single manifest file when building an app, so this PR provides AndroidManifest.xml with network security config in debug folder, that will be used only for debug builds. Also the network security configuration will be applied to only app that target API 28. Moved security config file to xml-v28, so that it'll only visible to API 28 and above.
See https://developer.android.com/studio/build/manifest-merge
Changelog
[Android] [Changed] - Android Network Security configuration.
Test Plan
CI is green, and RN apps will work that targets API 28.